[settings] Add review feedback

This commit is contained in:
JohnHake 2020-05-20 21:37:11 -07:00
parent a6036bcd45
commit ef0f4eb089
4 changed files with 11 additions and 7 deletions

View File

@ -1,6 +1,6 @@
plugins {
id 'java'
id 'org.jetbrains.intellij' version '0.4.18'
id 'org.jetbrains.intellij' version '0.4.21'
}
group 'org.intellij.sdk'
@ -13,9 +13,14 @@ repositories {
// See https://github.com/JetBrains/gradle-intellij-plugin/
intellij {
version '2020.1'
sameSinceUntilBuild = true
}
buildSearchableOptions {
enabled = false
}
patchPluginXml {
version = project.version
sinceBuild = '201'
untilBuild = '201.*'
}

View File

@ -11,7 +11,7 @@ import org.jetbrains.annotations.NotNull;
import javax.swing.*;
/**
* This class has responsibility for creating and managing a JPanel for the Settings Dialog.
* Supports creating and managing a JPanel for the Settings Dialog.
*/
public class AppSettingsComponent {
private final JPanel myMainPanel;

View File

@ -11,10 +11,9 @@ import javax.swing.*;
/**
* Provides controller functionality for application settings.
* See com.intellij.openapi.options.Configurable for additional documentation.
*/
public class AppSettingsConfigurable implements Configurable {
private AppSettingsComponent mySettingsComponent = null;
private AppSettingsComponent mySettingsComponent;
// A default constructor with no arguments is required because this implementation
// is registered as an applicationConfigurable EP

View File

@ -11,8 +11,8 @@ import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;
/**
* This class is responsible for storing the application settings in a persistent way.
* The State and Storage macros define the name of the data and the file name where
* Supports storing the application settings in a persistent way.
* The State and Storage annotations define the name of the data and the file name where
* these persistent application settings are stored.
*/
@State(