hxuanyu/intellij-sdk-code-samples
1
0
Fork 0
mirror of https://github.com/JetBrains/intellij-sdk-code-samples.git synced 2025-07-27 16:57:49 +08:00
Code Issues Packages Projects Releases Wiki Activity

[Code Samples Inspection] Java > Control flow issues > Redundant 'if' statement

Browse Source
This commit is contained in:
Jakub Chrzanowski 2020-04-16 11:17:22 +02:00
parent 56cefc5580
commit e4a93ccf13
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
conditional_operator_intention/src/main/java/org/intellij/sdk/intention/ConditionalOperatorConverter.java
View File

@ -70,11 +70,8 @@ public class ConditionalOperatorConverter extends PsiElementBaseIntentionAction
// Is this token part of a fully formed conditional, i.e. a ternary?
if (token.getParent() instanceof PsiConditionalExpression) {
final PsiConditionalExpression conditionalExpression = (PsiConditionalExpression) token.getParent();
if (conditionalExpression.getThenExpression() == null
|| conditionalExpression.getElseExpression() == null) {
return false;
}
return true; // Satisfies all criteria; call back invoke method
return conditionalExpression.getThenExpression() != null
&& conditionalExpression.getElseExpression() != null;// Satisfies all criteria; call back invoke method
}
return false;
}