UX-2323 Update existing UI Guidelines: Built-in Button, fix review comments

This commit is contained in:
marianna.kononenko 2025-01-17 17:01:56 +01:00
parent 74469f1258
commit 69b6542270
8 changed files with 21 additions and 23 deletions

Binary file not shown.

Before

Width:  |  Height:  |  Size: 17 KiB

After

Width:  |  Height:  |  Size: 17 KiB

Binary file not shown.

After

Width:  |  Height:  |  Size: 3.9 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 28 KiB

After

Width:  |  Height:  |  Size: 25 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 64 KiB

After

Width:  |  Height:  |  Size: 64 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 5.7 KiB

After

Width:  |  Height:  |  Size: 5.8 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 5.3 KiB

After

Width:  |  Height:  |  Size: 5.4 KiB

Binary file not shown.

Before

Width:  |  Height:  |  Size: 19 KiB

After

Width:  |  Height:  |  Size: 20 KiB

View File

@ -11,8 +11,9 @@ A built-in button is an icon placed inside an input control.
## When to use ## When to use
### Browse ### Browse
The **Browse** button opens a dialog with the disk, a tree view, or a table of values. The **Browse** button shows a dialog for opening files from the disk, a tree view, or a table of values.
Use the **Browse** icon for a file/folder path selected from the disk: Use the **Browse** icon to select a single file or a folder from the disc.
<img src="built_in_button_browse.png" alt="Browse" width="706"/> <img src="built_in_button_browse.png" alt="Browse" width="706"/>
[//]: # (An input field with browse button: [`TextFieldWithBrowseButton`]&#40;%gh-ic%/platform/platform-api/src/com/intellij/openapi/ui/TextFieldWithBrowseButton.java&#41;) [//]: # (An input field with browse button: [`TextFieldWithBrowseButton`]&#40;%gh-ic%/platform/platform-api/src/com/intellij/openapi/ui/TextFieldWithBrowseButton.java&#41;)
@ -79,6 +80,7 @@ use the **Expand** button to expand the control
![Collapsed built-in button](built_in_button_collapsed.png){width=706} ![Collapsed built-in button](built_in_button_collapsed.png){width=706}
When the field is expanded, show the **Collapse** button: When the field is expanded, show the **Collapse** button:
![Expanded built-in button](built_in_button_expanded.png){width=706} ![Expanded built-in button](built_in_button_expanded.png){width=706}
### List values ### List values
@ -88,9 +90,7 @@ Use the **List** icon to select a value from the list of classes, methods, or en
![List of values](built_in_button_list.png){width=706} ![List of values](built_in_button_list.png){width=706}
### Add value ### Add value
Use the **Add** button to select multiple values, such as files, variables, folder paths. The selected values will be added to the existing list.
The **Plus** button works the same way as the **[Browse](#browse)** button.
The only difference is that the selected value is added instead of overwriting the existing one.
![Add a value to the field](built_in_button_add.png){width=706} ![Add a value to the field](built_in_button_add.png){width=706}
@ -99,12 +99,10 @@ The only difference is that the selected value is added instead of overwriting t
Place the built-in button inside the input field. Do not place the built-in button next to the field control: Place the built-in button inside the input field. Do not place the built-in button next to the field control:
<table style="none" border="false"> <table style="none" border="false">
<tr> <tr>
<td><format color="369650" style="bold">Correct</format></td> <td><format color="369650" style="bold">Correct</format>
<td><format color="E55765" style="bold">Incorrect</format></td> <img src="built_in_button_browse_correct.png" alt="Browse button" width="378"/></td>
</tr> <td><format color="E55765" style="bold">Incorrect</format>
<tr> <img src="built_in_button_browse_incorrect.png" alt="Incorrect browse button" width="378"/></td>
<td><img src="built_in_button_browse_correct.png" alt="Browse button" width="378"/></td>
<td><img src="built_in_button_browse_incorrect.png" alt="Incorrect browse button" width="378"/></td>
</tr> </tr>
</table> </table>
@ -119,12 +117,14 @@ The shortcut for a built-in button is <shortcut>Shift+Enter</shortcut>.
Do not use the **Copy**, **Paste** or **Cut** button. Instead, make sure these actions are available on pressing <shortcut>Cmd/Ctrl+X</shortuct>, <shortcut>Cmd/Ctrl+C</shortuct>, and <shortcut>Cmd/Ctrl+V</shortuct> shortcuts or from the context menu. Do not use the **Copy**, **Paste** or **Cut** button. Instead, make sure these actions are available on pressing <shortcut>Cmd/Ctrl+X</shortuct>, <shortcut>Cmd/Ctrl+C</shortuct>, and <shortcut>Cmd/Ctrl+V</shortuct> shortcuts or from the context menu.
<table style="none" border="false"> <table style="none" border="false">
<tr> <tr>
<td><format color="369650" style="bold">Correct</format></td> <td>
<td><format color="E55765" style="bold">Incorrect</format></td> <format color="369650" style="bold">Correct</format>
</tr> <img src="built_in_button_copy_correct.png" alt="Browse button" width="378"/>
<tr> </td>
<td><img src="built_in_button_copy_correct.png" alt="Browse button" width="378"/></td> <td>
<td><img src="built_in_button_copy_incorrect.png" alt="Incorrect browse button" width="378"/></td> <format color="E55765" style="bold">Incorrect</format>
<img src="built_in_button_copy_incorrect.png" alt="Incorrect browse button" width="378"/>
</td>
</tr> </tr>
</table> </table>
@ -133,11 +133,9 @@ Do not use the **Help** or **Info** buttons to open an external link or a hint.
<table style="none" border="false"> <table style="none" border="false">
<tr> <tr>
<td><format color="369650" style="bold">Correct</format></td> <td><format color="369650" style="bold">Correct</format>
<td><format color="E55765" style="bold">Incorrect</format></td> <img src="built_in_button_help_correct.png" alt="Context help " width="378"/></td>
</tr> <td><format color="E55765" style="bold">Incorrect</format>
<tr> <img src="built_in_button_help_incorrect.png" alt="Incorrect browse button" width="378"/></td>
<td><img src="built_in_button_help_correct.png" alt="Context help " width="378"/></td>
<td><img src="built_in_button_help_incorrect.png" alt="Incorrect browse button" width="378"/></td>
</tr> </tr>
</table> </table>